Skip to content

Commit

Permalink
Adjust spacing in suggestion, add a test
Browse files Browse the repository at this point in the history
  • Loading branch information
compiler-errors committed Sep 8, 2022
1 parent 30e3673 commit 48281b0
Show file tree
Hide file tree
Showing 9 changed files with 50 additions and 12 deletions.
4 changes: 2 additions & 2 deletions compiler/rustc_middle/src/ty/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ pub fn suggest_arbitrary_trait_bound<'tcx>(
// FIXME: this case overlaps with code in TyCtxt::note_and_explain_type_err.
// That should be extracted into a helper function.
if constraint.ends_with('>') {
constraint = format!("{}, {}={}>", &constraint[..constraint.len() - 1], name, term);
constraint = format!("{}, {} = {}>", &constraint[..constraint.len() - 1], name, term);
} else {
constraint.push_str(&format!("<{}={}>", name, term));
constraint.push_str(&format!("<{} = {}>", name, term));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -608,13 +608,13 @@ impl<'a, 'tcx> InferCtxtExt<'tcx> for InferCtxt<'a, 'tcx> {
// That should be extracted into a helper function.
if constraint.ends_with('>') {
constraint = format!(
"{}, {}={}>",
"{}, {} = {}>",
&constraint[..constraint.len() - 1],
name,
term
);
} else {
constraint.push_str(&format!("<{}={}>", name, term));
constraint.push_str(&format!("<{} = {}>", name, term));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/generic-associated-types/missing-bounds.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ impl<B: Add + Add<Output = B>> Add for C<B> {

struct D<B>(B);

impl<B: std::ops::Add<Output=B>> Add for D<B> {
impl<B: std::ops::Add<Output = B>> Add for D<B> {
type Output = Self;

fn add(self, rhs: Self) -> Self {
Expand Down
4 changes: 2 additions & 2 deletions src/test/ui/generic-associated-types/missing-bounds.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ LL | Self(self.0 + rhs.0)
|
help: consider restricting type parameter `B`
|
LL | impl<B: std::ops::Add<Output=B>> Add for D<B> {
| +++++++++++++++++++++++++
LL | impl<B: std::ops::Add<Output = B>> Add for D<B> {
| +++++++++++++++++++++++++++

error[E0308]: mismatched types
--> $DIR/missing-bounds.rs:42:14
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/suggestions/issue-97677.fixed
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// run-rustfix

fn add_ten<N: std::ops::Add<i32, Output=N>>(n: N) -> N {
fn add_ten<N: std::ops::Add<i32, Output = N>>(n: N) -> N {
n + 10
//~^ ERROR cannot add `{integer}` to `N`
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/ui/suggestions/issue-97677.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ LL | n + 10
|
help: consider restricting type parameter `N`
|
LL | fn add_ten<N: std::ops::Add<i32, Output=N>>(n: N) -> N {
| ++++++++++++++++++++++++++++++
LL | fn add_ten<N: std::ops::Add<i32, Output = N>>(n: N) -> N {
| ++++++++++++++++++++++++++++++++

error: aborting due to previous error

Expand Down
12 changes: 12 additions & 0 deletions src/test/ui/suggestions/restrict-type-not-param.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
use std::ops::Add;

struct Wrapper<T>(T);

trait Foo {}

fn qux<T>(a: Wrapper<T>, b: T) -> T {
a + b
//~^ ERROR cannot add `T` to `Wrapper<T>`
}

fn main() {}
26 changes: 26 additions & 0 deletions src/test/ui/suggestions/restrict-type-not-param.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
error[E0369]: cannot add `T` to `Wrapper<T>`
--> $DIR/restrict-type-not-param.rs:8:7
|
LL | a + b
| - ^ - T
| |
| Wrapper<T>
|
note: an implementation of `Add<_>` might be missing for `Wrapper<T>`
--> $DIR/restrict-type-not-param.rs:3:1
|
LL | struct Wrapper<T>(T);
| ^^^^^^^^^^^^^^^^^ must implement `Add<_>`
note: the following trait must be implemented
--> $SRC_DIR/core/src/ops/arith.rs:LL:COL
|
LL | pub trait Add<Rhs = Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider introducing a `where` clause, but there might be an alternative better way to express this requirement
|
LL | fn qux<T>(a: Wrapper<T>, b: T) -> T where Wrapper<T>: Add<T, Output = T> {
| ++++++++++++++++++++++++++++++++++++

error: aborting due to previous error

For more information about this error, try `rustc --explain E0369`.
4 changes: 2 additions & 2 deletions src/test/ui/traits/resolution-in-overloaded-op.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ LL | a * b
|
help: consider introducing a `where` clause, but there might be an alternative better way to express this requirement
|
LL | fn foo<T: MyMul<f64, f64>>(a: &T, b: f64) -> f64 where &T: Mul<f64, Output=f64> {
| ++++++++++++++++++++++++++++++
LL | fn foo<T: MyMul<f64, f64>>(a: &T, b: f64) -> f64 where &T: Mul<f64, Output = f64> {
| ++++++++++++++++++++++++++++++++

error: aborting due to previous error

Expand Down

0 comments on commit 48281b0

Please sign in to comment.