Refactor code (Make comments looks more cleaner.)#20
Open
Marvel999 wants to merge 2 commits intosparrow007:mainfrom
Open
Refactor code (Make comments looks more cleaner.)#20Marvel999 wants to merge 2 commits intosparrow007:mainfrom
Marvel999 wants to merge 2 commits intosparrow007:mainfrom
Conversation
Owner
|
Hi @Marvel999 thanks for the PR, I'll review it soon and update you accordingly. |
Owner
|
@Marvel999 We are having few changes in the LayoutManager and recyclerView so after updating all those files, there is conflicts are showing. would you please resolve it with main branch. |
Author
|
Hey @sparrow007, I have resolved the conflict please check by building in your local system. |
Owner
|
@Marvel999 Thanks for the update but there are other changes i am doing for the fixes so this PR still be pending for next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor formatting(Spacing) and make comments look cleaner.