fix: treat name as array of chars instead of pointer to heap address

sparky-game · Jun 8, 2024 · aad86f6 · aad86f6
1 parent 00e8f43
commit aad86f6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/tools/skap/include/skap_idx_image.h b/tools/skap/include/skap_idx_image.h
@@ -25,8 +25,10 @@
 #include <raylib.h>
 #include <skap_defines.h>
 
+#define SKAP_IDX_IMAGE_MD_NAME_MAX_LEN 512
+
 typedef struct {
-  const char *name;
+  char name[SKAP_IDX_IMAGE_MD_NAME_MAX_LEN];
   u32 width;
   u32 height;
   u32 mipmaps;

diff --git a/tools/skap/src/skap_idx_image.c b/tools/skap/src/skap_idx_image.c
@@ -20,6 +20,7 @@
 
 
 #include <assert.h>
+#include <string.h>
 #include <skap_idx_image.h>
 
 void skap_idx_image_loadall(Image *imgs, const char **img_paths, usz size) {
@@ -37,9 +38,8 @@ void skap_idx_image_unloadall(Image *imgs, usz size) {
 }
 
 skap_idx_image skap_idx_image_create(const char *name, Image *img) {
-  return (skap_idx_image) {
+  skap_idx_image i = {
     .metadata = (skap_idx_image_md) {
-      .name = name,
       .width = img->width,
       .height = img->height,
       .mipmaps = img->mipmaps,
@@ -48,6 +48,9 @@ skap_idx_image skap_idx_image_create(const char *name, Image *img) {
     .blob_offset = 0,
     .blob_size = 0
   };
+  memset(i.metadata.name, 0, sizeof(i.metadata.name));
+  strncpy(i.metadata.name, name, sizeof(i.metadata.name) - 1);
+  return i;
 }
 
 u8 skap_idx_image_append(FILE *fd, skap_idx_image *i) {