Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated node-sass dependency with sass #850

Closed
3 of 5 tasks
0xdevalias opened this issue Dec 2, 2020 · 1 comment · Fixed by #1103
Closed
3 of 5 tasks

Replace deprecated node-sass dependency with sass #850

0xdevalias opened this issue Dec 2, 2020 · 1 comment · Fixed by #1103
Assignees

Comments

@0xdevalias
Copy link
Contributor

0xdevalias commented Dec 2, 2020

Once create-react-app / react-scripts supports it, we should upgrade from the deprecated node-sass dependency to the Dart based sass

Related upstream issues:

See also:

@0xdevalias
Copy link
Contributor Author

From #850:


Since we already seem to be using a version of saas-loader that supports the non-deprecated dart-sass, and because create-react-app's react-scripts doesn't seem to support node-sass v5 yet (targeted for 4.0.2 milestone), I think our best way forward here is to switch to using dart-sass instead of this.

Originally posted by @0xdevalias in #1079 (comment)

@0xdevalias 0xdevalias removed the blocked-by-dependency This issue is blocked by an issue in another dependency. label Jan 25, 2021
@0xdevalias 0xdevalias self-assigned this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant