Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exercise fragment construction with a context Element #2709

Merged

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Nov 30, 2022

What problem is this PR intended to solve?

exercise fragment construction with a context Element, in addition to the existing tests that use the context element name

Closes #2697

Before:
4191 tests, 58094 assertions, 0 failures, 0 errors, 17 skips

After:
4385 tests, 60489 assertions, 0 failures, 0 errors, 17 skips

in addition to the existing tests that use the context element name

Closes #2697
@flavorjones flavorjones force-pushed the 2697-run-html5-fragment-tests-with-a-context-node branch from 52e6f0e to eff81ee Compare November 30, 2022 17:05
@flavorjones flavorjones added this to the v1.14.0 milestone Nov 30, 2022
Copy link
Contributor

@stevecheckoway stevecheckoway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to test using a context node. This LGTM.

@flavorjones flavorjones merged commit 6d2c1fa into main Dec 1, 2022
@flavorjones flavorjones deleted the 2697-run-html5-fragment-tests-with-a-context-node branch December 1, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run html5lib-tests fragment construction tests with an instantiated context node
2 participants