Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] using windows system libxml 2.9.12 segfaults on exit #2241

Closed
flavorjones opened this issue May 18, 2021 · 0 comments
Closed

[bug] using windows system libxml 2.9.12 segfaults on exit #2241

flavorjones opened this issue May 18, 2021 · 0 comments
Labels
platform/windows upstream/libxml2
Milestone
v1.11.x patch rel...

Comments

@flavorjones
Copy link
Member

flavorjones commented May 18, 2021 •
edited
Loading

Please describe the bug

When Appveyor and Github Actions upgraded their system libraries to libxml 2.9.12, the tests started segfaulting on exit.

Note specifically that the same version of Nokogiri running against system libxml 2.9.10 does not do this; nor does Nokogiri running against packaged libxml 2.9.12.

Additional context

There were some changes introduced into libxml 2.9.11/12 related to cleanup of windows DLLs at unload/exit time, which seem likely to be contributing causes here. Relevant links:
@flavorjones flavorjones added state/needs-triage Inbox for non-installation-related bug reports or help requests platform/windows upstream/libxml2 and removed state/needs-triage Inbox for non-installation-related bug reports or help requests labels May 18, 2021
@flavorjones flavorjones mentioned this issue May 18, 2021
Closed
flavorjones added a commit that referenced this issue May 19, 2021
@flavorjones
windows: work around libxml2 xmlCleanupParser
942d38f 
Closes #2241
@flavorjones flavorjones mentioned this issue May 19, 2021
Merged
flavorjones added a commit that referenced this issue May 19, 2021
@flavorjones
Merge pull request #2240 from sparklemotion/flavorjones-update-tests-…
e5640dc 
…to-work-with-system-libxml-2_9_12

test: adjust tests to pass on system libxml2 >= 2.9.11, and work around windows dll unloading issue

---

**What problem is this PR intended to solve?**

Adjust tests to pass on system libxml2 >= 2.9.11, because the comment parsing improvement was merged upstream. See https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/82 for context (and the recently removed `htmlParseComment` patch). This will allow us to run tests regularly against upstream master.

Also, work around the libxml2 issue described in #2241 by having libxml2 use its default memory management on windows when system libraries are being used. Note that this also introduces a new value into `Nokogiri::VERSION_INFO`, which is "libxml → memory_management", and the value will be either "ruby" or "default".
flavorjones added a commit that referenced this issue May 19, 2021
@flavorjones
windows: work around libxml2 xmlCleanupParser
e6709aa 
Closes #2241
@flavorjones flavorjones mentioned this issue May 19, 2021
Merged
@flavorjones flavorjones added this to the v1.11.x patch releases milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform/windows upstream/libxml2
Projects
None yet
Milestone
v1.11.x patch releases
Development

No branches or pull requests
1 participant
@flavorjones