Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assert on download response being available #2547

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove assert on download response being available #2547

merged 1 commit into from
Apr 26, 2024

Conversation

zorgiepoo
Copy link
Member

This assert shouldn't be there because we have fallbacks for the response URL.

Fixes #2546

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Testing in CI

@zorgiepoo zorgiepoo added this to the 2.6.1 milestone Apr 26, 2024
@zorgiepoo zorgiepoo merged commit 5264c01 into 2.x Apr 26, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the remove-downloader-response-assert branch April 26, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.

Crash @ -[SPUDownloader downloadDidFinish] SPUDownloader.m, line 252
1 participant
@zorgiepoo