Perform Gatekeeper scan to pre-warm app launch #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids users being a "Verifying..." Dialog when the installed update is (re-)launched. This scan is only done for macOS 14.4+ onwards (gktool was introduced in macOS 14.0 but had issues). Also this scan is only done if Autoupdate's team identifier matches the new update's team identifier. Otherwise the OS may think Autoupdate is modifying a bundle which it shouldn't be permitted to (this is a bug).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids users seeing a "Verifying..." Dialog when the installed update is (re-)launched.
This scan is only done for macOS 14.4+ onwards (gktool was introduced in macOS 14.0 but had issues).
Also this scan is only done if Autoupdate's team identifier matches the new update's team identifier. Otherwise the OS may think Autoupdate is modifying a bundle that it shouldn't be permitted to.
Fixes #2491
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested updating my own notarized app and saw gktool run without issue when Autoupdate & app bundle to be updated are signed with same Team Identifier. Tested gktool is not ran when Team Identifier differs or system is running an OS before 14.4.
macOS version tested:
14.4 Beta (23E5196e)
14.3 (23D56) (skipped)