Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Package.swift minimum deployment to macOS 10.13 #2481

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Dec 27, 2023

This was not included in #2196.

In one project we mistakenly included Sparkle 2.3+ in an app that still supported macOS 10.12. Xcode did not give a warning or build error and I could not figure out why. I suppose that this commit resolves that.

Fixes # (issue)

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

(Describe all the cases that were tested)

macOS version tested: [place version here]

@zorgiepoo zorgiepoo added this to the 2.6 milestone Dec 27, 2023
@zorgiepoo
Copy link
Member

zorgiepoo commented Dec 27, 2023

Thanks. Yeah, the Package.swift file is not included in the Xcode project and it would be easy to not grep for "10_11". I will somehow need to keep better track of this in the future.

However this is not really a big deal. The last couple years of Xcode releases don't support deploying to less than 10.13 anyway. No Mac developer should be targeting a deployment target less than 10.13. It is not supported and may not work correctly in very subtle if not obvious ways. This is why the deployment target was bumped.

There should also be a separate linker warning (unrelated to SPM) about linking a framework whose deployment target exceeds the deployment target of the binary linking it. I am pretty sure from memory this warning exists. However again, 10.12 deployment target isn't supported by Xcode.

@zorgiepoo zorgiepoo merged commit 485f0e6 into sparkle-project:2.x Dec 27, 2023
2 checks passed
@Eitot Eitot deleted the spm branch December 28, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants