Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve signing error message to developers #2471

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

zorgiepoo
Copy link
Member

If we detect the wrong archive is being served (i.e, expected content length differs from archive length) we log this out to developers. If the app version in the archive (if available) also differs, we report this discrepancy as well. If the update archive looks the same but signing validation fails, we tell the developer the update may have not been signed correctly.

Fixes #2468

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested update succeed without errors
Tested update fail with matching content length and version (app bundle, pkg)
Tested update fail with non-matching content length and matching version (app bundle, pkg)
Tested update fail with non-matching content length and non-matching version (app bundle, pkg)

macOS version tested: 14.0 (23A344)

If we detect the wrong archive is being served (i.e, expected content length differs from archive length) we log this out to developers. If the app version in the archive (if available) also differs, we report this discrepancy as well. If the update archive looks the same but signing validation fails, we tell the developer the update may have not been signed correctly.

Fixes #2468
@zorgiepoo zorgiepoo added this to the 2.6 milestone Nov 18, 2023
@zorgiepoo zorgiepoo merged commit 1e419c8 into 2.x Nov 19, 2023
2 checks passed
@zorgiepoo zorgiepoo deleted the elaborate-signing-error branch November 19, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve signing error message to developers if the wrong file is being served
1 participant