Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose maximum-versions option to preserve in feed per branch #2259

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

zorgiepoo
Copy link
Member

Also let a zero or negative value mean that all versions should be preserved.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested generate_appcast using this option and passing different values to it, including 0.

macOS version tested: 12.5.1 (21G83)

@zorgiepoo zorgiepoo added this to the 2.3 milestone Sep 5, 2022
@zorgiepoo zorgiepoo merged commit 1b1a7db into 2.x Sep 5, 2022
@zorgiepoo zorgiepoo deleted the maximum-versions branch September 5, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant