Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize usage of XPC connections to main queue #2178

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

zorgiepoo
Copy link
Member

Synchronize usage of XPC connections to main queue to prevent potential race conditions.

Maybe fixes #2176

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested test app with and without using connection/status XPC Services, when there is already a staged update available to be installed and when there isn't.

macOS version tested: 12.4 (21F79)

@zorgiepoo zorgiepoo added this to the 2.2 milestone Jun 25, 2022
@zorgiepoo zorgiepoo merged commit d544d45 into 2.x Jun 26, 2022
@zorgiepoo zorgiepoo deleted the harden-connection-sync branch June 26, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: -[SUInstallerStatus probeStatusInfoWithReply:]
1 participant