Replace deprecated code with newer APIs #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kUTType* constants are deprecated since macOS 12. The UniformTypeIdentifiers framework is available since the macOS 11 SDK.
zorgiepoo
reviewed
Apr 24, 2022
|
Looks good besides one weak linkage concern. After that I will probably give it a basic test run on one of my VMs running < macOS 11. |
|
Merge conflict from previous changes. |
|
Gave a run on macOS 10.12, seems good, thanks! |
|
(The deprecated keychain & security APIs are only used for DSA keys btw which we've deprecated ourselves). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the static analyser with the deployment target set to macOS 12.3 to see if any deprecation warnings show up. These commits address some of those warnings (e.g. not the C-based Keychain APIs) by using newer APIs where available.
Misc Checklist:
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
macOS version tested: 12.3.1