Repository navigation
Conversation
In order to code sign Sparkle when installing via a Pod, the `Entitlements` directory needs to be available.
Member
|
Thanks. This only affects developers that use the Downloader XPC Service and use a manual re-signing workflow (otherwise Xcode's archive/export process preserves the entitlement). Workaround is fetching the entitlements file from the repo or a distribution. (If you do use the Downloader XPC Service please file a bug to Apple about not being able to use WebKit2). |
Contributor
Author
|
Thanks @zorgiepoo! Although I don't use the Downloader XPC, it do have a manual signing process. So the simplest thing at the moment is to sign it and just not enable it. |
Member
|
Ah well, if you don't use it, it doesn't really matter a whole lot how it gets signed because it will be unused. You could technically even remove it if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to code sign Sparkle when installing via a Pod, the
Entitlementsdirectory needs to be available.(Insert summary of your pull request here)
Fixes #2062
Misc Checklist:
My change requires a documentation update on Sparkle's website repositoryMy change requires changes to generate_appcast, generate_keys, or sign_updateOnly bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
(Describe all the cases that were tested)
macOS version tested: 12.1