Skip to content

Commented RECEIVE_TIMEOUT_VALUE as variable seems unused #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2021
Merged

Commented RECEIVE_TIMEOUT_VALUE as variable seems unused #11

merged 3 commits into from
Dec 15, 2021

Conversation

@gb-123-git
Copy link
Contributor

@gb-123-git gb-123-git commented Nov 20, 2021

The variables 'RECEIVE_TIMEOUT_VALUE' in SX1509::readByte & SX1509::readWord seem to be unused. Commented.

@gb-123-git
Commented RECEIVE_TIMEOUT_VALUE as variable seems unused
661570c 
The variables 'RECEIVE_TIMEOUT_VALUE' in SX1509::readByte & SX1509::readWord seem to be unused. Commented.
@gb-123-git
Update SparkFunSX1509.cpp
b4aac50
@gb-123-git
Bug Fix
e3d7bbd
@gb-123-git
Copy link
Contributor Author

gb-123-git commented Nov 29, 2021

  1. Commented a missed timeout line.
  2. Another bugfix to remove compiler warnings.

@nseidle
Copy link
Member

nseidle commented Dec 15, 2021

Thank you very much for the PR! Looks good.

@nseidle nseidle merged commit 580d93d into sparkfun:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gb-123-git @nseidle