simplify L-band console message logic #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might have been a left-over from a previous refactor of platform detection. Both callers already detect if L-band is online. This was needed for a custom hardware platform but is equally applicable to SparkFun units.
Member
|
Thank you! The recent uptick in PRs to this codebase is awesome and we welcome it. But please know we are only doing bug updates here. We will try to include this in our next release. RTK Everywhere is where we are actively developing. If you or other folks with custom hardware need a landing spot for development, please let us know. We're pretty focused on our target hardware but we have no qualms with custom or DIY projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might have been a left-over from a previous refactor of platform detection. Both callers already detect if L-band is online.
This was needed for a custom hardware platform but is equally applicable to SparkFun units.