Skip to content

Conversation

@LeeLeahy2
Copy link
Collaborator

This pull request includes the following commits:

  • WebSockets: Split out webSockets from webServer
  • WebSockets: Use webSocketsIsConnected() instead of websocketConnected
  • WebSockets: Update start messages
  • menuCommands: Protect against settingsCSV being nullptr
  • WebSockets: Add webSockets to the messages
  • webSockets: Add list of active clients

@PaulZC
Copy link
Contributor

PaulZC commented Dec 9, 2025

Hi Lee (@LeeLeahy2 ) and Nathan (@nseidle ),

This is good stuff!

But please be aware that there is a lot of overlap between this PR and #827.

I propose we merge this PR and #832 first. If there is anything from #827 that still needs to be included, I will open a new PR to cover that.

(If we try to merge #827 and this PR, we'll get into a big old mess!)

All the best,
Paul

@PaulZC PaulZC mentioned this pull request Dec 9, 2025
@nseidle nseidle merged commit ad9e10e into sparkfun:release_candidate Dec 9, 2025
@LeeLeahy2 LeeLeahy2 deleted the web-sockets branch December 9, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants