Add minor features for top articles #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
000wan
force-pushed
the
feat/top-articles
branch
from
f5d19e0 to
464ac22
Compare
injoonH
reviewed
Aug 23, 2023
Comment on lines
+248
to
+249
| before = articles.filter(topped_at__lte=obj.topped_at).first() | ||
| after = articles.filter(topped_at__gte=obj.topped_at).last() |
There was a problem hiding this comment.
221번 줄에서 articles = articles.exclude(id=obj.id) 해줘서 제외되는거 같아요 !
|
sparcs-kaist/new-ara-web#390 프론트 작업 마무리되어서 이 PR 리뷰해주시면 될 것 같아요~ |
injoonH
approved these changes
Aug 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 슬랙 스레드
이 외 변경사항은 pre-commit이 작동 안되서
pre-commit autoupdate돌리면서 생긴 것들 입니다.