Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken CI -- codspeed-benchmarks #981

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

VishnuSanal
Copy link
Contributor

@VishnuSanal VishnuSanal commented Oct 12, 2024

Description

This PR fixes #980

Summary

This PR does update the codspeed action version from v2 to v3. since ubuntu-latest (which currently is 24.04) is curretnly unsupported for CodSpeedHQ/action@v2.

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Oct 12, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #981 will not alter performance

Comparing VishnuSanal:patch-1 (160500d) with main (028f161)

Summary

✅ 116 untouched benchmarks

@sansyrox
Copy link
Member

@VishnuSanal , this update breaks the ci.

Run # Configure and run codspeed-runner

   ______            __ _____                         __
  / ____/____   ____/ // ___/ ____   ___   ___   ____/ /
 / /    / __ \ / __  / \__ \ / __ \ / _ \ / _ \ / __  /
/ /___ / /_/ // /_/ / ___/ // /_/ //  __//  __// /_/ /
\____/ \____/ \__,_/ /____// .___/ \___/ \___/ \__,_/
  https://codspeed.io/     /_/          runner v3.0.0

Error: Error: Only Ubuntu 20.04 and 22.04 are supported at the moment
Error: Process completed with exit code 1.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 5:57pm

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Great work @VishnuSanal

@sansyrox sansyrox merged commit 74cdabf into sparckles:main Oct 12, 2024
60 checks passed
@VishnuSanal VishnuSanal deleted the patch-1 branch October 13, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken CI: codspeed-benchmarks
2 participants