Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a close method in websockets #946

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Aug 25, 2024

Description

This PR fixes #782

Summary

This PR introduces a close method in websockets

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 8:42pm

Copy link

codspeed-hq bot commented Aug 25, 2024

CodSpeed Performance Report

Merging #946 will not alter performance

Comparing feat/add-close-websocket (202ee41) with main (b5797a8)

Summary

✅ 114 untouched benchmarks

@sansyrox sansyrox force-pushed the feat/add-close-websocket branch from db26f9f to 9c26128 Compare August 25, 2024 20:41
@sansyrox sansyrox merged commit c77ab5a into main Aug 25, 2024
79 checks passed
@sansyrox sansyrox deleted the feat/add-close-websocket branch August 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket close method feature
1 participant