-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: openapi request bodies #937
Conversation
@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #937 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super happy with the interface here. @VishnuSanal , we need to allow either a class or a typeddict like in query params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VishnuSanal ,
needs fixing.
The body should resemble the style of query params |
@VishnuSanal , this should be the interface
|
95f4165
to
32e8e03
Compare
c9d402e
to
9df1f60
Compare
https://github.com/sparckles/Robyn/actions/runs/10579769894/job/29313024961 please try rerunning. Issue is with websocket tests. |
@VishnuSanal , is this PR up for review? |
@VishnuSanal , could you please show the example of the openapi page generated? Attach a screenshot? |
Yep @sansyrox |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Amazing! ✨ class CreateItemBody(TypedDict):
name: Optional[str]
description: str
price: float
tax: float
@app.post("/upload/file")
def create_item(request: Request, body: CreateItemBody):
return request.body But we can address that in the next PR when we add support for response schemas! GG @VishnuSanal . Need to give a final review |
@sansyrox example ☝🏿 |
Love this @VishnuSanal ✨ Doing a final review before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😄
Good job!
Description
This PR fixes #935
Summary
This PR does add request bodies to openapi implementation.
PR Checklist
Please ensure that:
Pre-Commit Instructions: