Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openapi implementation #890

Merged
merged 73 commits into from
Aug 17, 2024
Merged

feat: openapi implementation #890

merged 73 commits into from
Aug 17, 2024

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #247

Copy link

vercel bot commented Jul 10, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@sansyrox
Copy link
Member

Hey @VishnuSanal 👋

Before you proceed further. Just one clarification OpenAPI is supposed to be generated automatically from the types.

Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #890 will not alter performance

Comparing VishnuSanal:openapi (10e747d) with main (1d555c9)

Summary

✅ 110 untouched benchmarks

🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main VishnuSanal:openapi Change
🆕 test_add_openapi_path N/A 15.8 ms N/A
🆕 test_add_subrouter_paths N/A 15.9 ms N/A
🆕 test_docs_handler N/A 4.7 ms N/A
🆕 test_json_handler N/A 15.9 ms N/A

@VishnuSanal
Copy link
Contributor Author

VishnuSanal commented Jul 17, 2024

TODO:

  • path param type
  • path param required?:
  • query params

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VishnuSanal 👋

I have a few suggestions that can improve the code style. These are just initial ones. I will do a thorough review when you put the PR up for review 😄

robyn/__init__.py Outdated Show resolved Hide resolved
robyn/__init__.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
@VishnuSanal VishnuSanal marked this pull request as ready for review July 26, 2024 05:26
@VishnuSanal VishnuSanal requested a review from sansyrox July 26, 2024 05:26
@sansyrox
Copy link
Member

Hey @VishnuSanal 👋

Could you please summarise the PR in the description?

robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
robyn/openapi.py Outdated Show resolved Hide resolved
@VishnuSanal VishnuSanal requested a review from sansyrox August 15, 2024 16:15
Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 0:10am

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @VishnuSanal

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @VishnuSanal 👍

@sansyrox sansyrox merged commit 84db4cd into sparckles:main Aug 17, 2024
60 checks passed
@tavallaie
Copy link
Contributor

Thansk @VishnuSanal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add openapi integration
3 participants