-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: openapi implementation #890
Conversation
@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
Hey @VishnuSanal 👋 Before you proceed further. Just one clarification OpenAPI is supposed to be generated automatically from the types. |
CodSpeed Performance ReportMerging #890 will not alter performanceComparing Summary
Benchmarks breakdown
|
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VishnuSanal 👋
I have a few suggestions that can improve the code style. These are just initial ones. I will do a thorough review when you put the PR up for review 😄
Hey @VishnuSanal 👋 Could you please summarise the PR in the description? |
Co-authored-by: Sanskar Jethi <[email protected]>
Co-authored-by: Ali Tavallaie <[email protected]>
for more information, see https://pre-commit.ci
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @VishnuSanal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @VishnuSanal 👍
Thansk @VishnuSanal |
Description
This PR fixes #247