-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal mypy update to openapy.py, adding dict type #1048
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @dave42w 😄
CodSpeed Performance ReportMerging #1048 will not alter performanceComparing Summary
|
Hey @sansyrox I have a fix for the mypy errors with the way we are using TypedDict for variables eg
the fix is a new class
which is then used like this:
and
and tested like this:
All tests pass and now we have no mypy warnings in OpenApi Are you happy for me to commit this change? |
@dave42w , yes ! Go ahead and thank you 😄 |
Done :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR just fixes the missing dict type in 3 places so that mypy warnings are reduced.
PR Checklist
Please ensure that:
Pre-Commit Instructions: