Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tiny corrections found by mypy 1.13 #1032

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Two tiny corrections found by mypy 1.13 #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3244226
Fixed reuse of local route_type as different types
dave42w Nov 16, 2024
b347d17
added dict type to self.methods
dave42w Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions robyn/processpool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ def spawn_process(
for middleware_type, middleware_function in global_middlewares:
server.add_global_middleware(middleware_type, middleware_function)

for route_type, endpoint, function in route_middlewares:
server.add_middleware_route(route_type, endpoint, function)
for http_route_type, endpoint, function in route_middlewares:
server.add_middleware_route(http_route_type, endpoint, function)

if Events.STARTUP in event_handlers:
server.add_startup_handler(event_handlers[Events.STARTUP])
Expand Down
2 changes: 1 addition & 1 deletion robyn/ws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class WebSocket:
def __init__(self, robyn_object: "Robyn", endpoint: str, config: Config = Config(), dependencies: DependencyMap = DependencyMap()) -> None:
self.robyn_object = robyn_object
self.endpoint = endpoint
self.methods = {}
self.methods: dict = {}
self.config = config
self.dependencies = dependencies

Expand Down
Loading