Revert #2698 forget_rooms_on_leave to upstream value #2700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts forget_rooms_on_leave to upstream as this is too dangerous to change in a breaking way like this is doing. Especially doing it together with a Call to Action to update your Synapses causing this change to enter all playbook users playbooks who update.
Its safe to keep the version bump part of #2698 but not safe to keep this change that this commit is undoing by setting the value to false. This means our config now includes the value like a upstream config would but we keep it at false just like upstream does.
This value is recomended to be made easily accessible and a Changelog note about this should be noted so that users know this setting exists if they want to use it as we should have a note explaining this event happened either way.