-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maubot moanos #1894
Merged
Merged
Maubot moanos #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansible-deploy into node_postgres_reverse_proxy
Cadair
reviewed
Jun 24, 2022
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
spantaleev
requested changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up and getting it to work! 🙇
I have some feedback that aims to make it more polished and more consistent with our naming conventions, etc.
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
roles/matrix-bot-maubot/templates/systemd/matrix-maubot.service.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Slavi Pantaleev <[email protected]>
Co-authored-by: Slavi Pantaleev <[email protected]>
No functionality changed
Co-authored-by: Slavi Pantaleev <[email protected]>
The /data is hardcoded in the container
This shall indicate that the public url of maubot is here configured the same as matrix_server_fqn_matrix but this must not be the case. In the config I used the matrix fqnd directly as this part of the config is directly bound to the homeserver we want to connect to (but can not use the internal)
spantaleev
reviewed
Jun 25, 2022
spantaleev
reviewed
Jul 9, 2022
roles/matrix-bot-maubot/templates/systemd/matrix-bot-maubot.service.j2
Outdated
Show resolved
Hide resolved
Reasoning: setup_install.yml only runs on --tags=setup-all or on --tags=setup-bot-maubot. If --tags=setup-nginx-proxy or similar commands are run, setup_install.yml will not run and the nginx configuration will be incomplete.
spantaleev
added a commit
that referenced
this pull request
Jul 20, 2022
spantaleev
added a commit
that referenced
this pull request
Jul 20, 2022
Related to #1894 Because the configuration file is now mounted as readonly and maubot tries to update it on start, we get this warning: > Failed to create tempfile to write updated config to disk: [Errno 30] Read-only file system: '/config/tmpfa8vcb3y.yaml' It doesn't seem to cause issues though. Because the configuration is no longer overwritten on every bot start, each next Ansible run should no longer overwrite it again and report a "changed" task.
spantaleev
added a commit
that referenced
this pull request
Jul 20, 2022
spantaleev
added a commit
that referenced
this pull request
Jul 20, 2022
…ctually make maubot port configurable Related to #1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is mainly based on #622 and for me it was easier copy the work that @Cadair did into my branch.
I tested this role and can successfully install maubot with reverse proxy and configuration options.
The role could be more configurable but I think it is a good start.
If this is something with perspective to be merged I can write up some documentation