Skip to content

gromacs: Add itt variant - #47764

Merged
alalazo merged 5 commits into
spack:developfrom
mabraham:mja-gromacs-intel-itt-variant
Nov 25, 2024
Merged

gromacs: Add itt variant#47764
alalazo merged 5 commits into
spack:developfrom
mabraham:mja-gromacs-intel-itt-variant

Conversation

@mabraham

Copy link
Copy Markdown
Contributor

Permit configuring GROMACS with support for mdrun to trace its timing regions by calling the ITT API. This permits tools like VTune and unitrace to augment their analysis with GROMACS-specific annotation.

Permit configuring GROMACS with support for mdrun to trace its timing
regions by calling the ITT API. This permits tools like VTune and
unitrace to augment their analysis with GROMACS-specific annotation.
junghans
junghans previously approved these changes Nov 24, 2024
alalazo
alalazo previously approved these changes Nov 25, 2024

@alalazo alalazo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a minor comment. Feel free to merge if you don't agree.

Comment thread var/spack/repos/builtin/packages/gromacs/package.py Outdated
@mabraham
mabraham dismissed stale reviews from alalazo and junghans via 3fd536e November 25, 2024 10:15
@mabraham mabraham changed the title gromacs: Add intel_itt variant gromacs: Add itt variant Nov 25, 2024
Comment thread var/spack/repos/builtin/packages/gromacs/package.py
@alalazo
alalazo merged commit 8e91430 into spack:develop Nov 25, 2024
@mabraham
mabraham deleted the mja-gromacs-intel-itt-variant branch November 27, 2024 08:41
fryeguy52 pushed a commit to fryeguy52/spack that referenced this pull request Dec 17, 2024
Permit configuring GROMACS with support for mdrun to trace its timing
regions by calling the ITT API. This permits tools like VTune and
unitrace to augment their analysis with GROMACS-specific annotation.
kshea21 pushed a commit to kshea21/spack that referenced this pull request Dec 26, 2024
Permit configuring GROMACS with support for mdrun to trace its timing
regions by calling the ITT API. This permits tools like VTune and
unitrace to augment their analysis with GROMACS-specific annotation.
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Feb 5, 2025
Permit configuring GROMACS with support for mdrun to trace its timing
regions by calling the ITT API. This permits tools like VTune and
unitrace to augment their analysis with GROMACS-specific annotation.
nkoukpaizan pushed a commit to nkoukpaizan/spack that referenced this pull request Apr 4, 2025
Permit configuring GROMACS with support for mdrun to trace its timing
regions by calling the ITT API. This permits tools like VTune and
unitrace to augment their analysis with GROMACS-specific annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants