Skip to content

verdict: new package - #47333

Merged
becker33 merged 3 commits into
developfrom
packages/verdict
Oct 30, 2024
Merged

verdict: new package#47333
becker33 merged 3 commits into
developfrom
packages/verdict

Conversation

@becker33

Copy link
Copy Markdown
Member

Working with @rblake-llnl who offered to be the maintainer for this.

@spackbot-app

spackbot-app Bot commented Oct 30, 2024

Copy link
Copy Markdown

@rblake-llnl can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • verdict

@alecbcs alecbcs changed the title new package: verdict verdict: new package Oct 30, 2024
@alecbcs

alecbcs commented Oct 30, 2024

Copy link
Copy Markdown
Member

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Oct 30, 2024

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Oct 30, 2024

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/verdict/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/verdict/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/variant.py:131: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]")  [operator]
Found 4 errors in 2 files (checked 621 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@becker33
becker33 enabled auto-merge (squash) October 30, 2024 21:03
@becker33
becker33 merged commit ce78e8a into develop Oct 30, 2024
@becker33
becker33 deleted the packages/verdict branch October 30, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants