New urls for Kokkos and Kokkos-Kernels - #47330
Merged
Merged
Conversation
spackbot-app
Bot
requested review from
brian-kelley,
lucbv,
nmm0 and
srajama1
October 30, 2024 16:18
lucbv
approved these changes
Oct 30, 2024
nmm0
approved these changes
Oct 30, 2024
nmm0
left a comment
nmm0
left a comment
Contributor
There was a problem hiding this comment.
Looks good, could probably get rid of explicit URLs
Contributor
Author
|
@bernhardkaindl, can you check if it fits Spack policy and merge if so? |
bernhardkaindl
left a comment
bernhardkaindl
left a comment
Contributor
There was a problem hiding this comment.
@bernhardkaindl, can you check if it fits Spack policy and merge if so?
I'm sorry, I can't because I don't know all of them. However, as @alalazo is active now, I mention him in this comment.
Feel free to ask him or a spack maintainer that likely knows better than me.
alalazo
approved these changes
Nov 4, 2024
This was referenced Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 4.4, Kokkos and Kokkos-Kernels have released signed tarballs.
This PR makes Spack use them instead of standard Github-generated artifacts.