miniforge3: wrong sbang replacement - #47178
Merged
bernhardkaindl merged 2 commits intoOct 24, 2024
Merged
Conversation
In the sbang line conda replaces the full path to the Python executable with `/usr/bin/env python` if the full path exceeds 127 characters. This does however break `conda deactivate` because the wrong Python interpreter is used after activating an environment. The 127 character limit is not relevant in Spack as Spack will automatically use the `sbang` script to deal with the overly long sbang line. There is no option to disable this replacement when running the miniforge installer, so the lines have to be changed after running the installer.
bernhardkaindl
previously approved these changes
Oct 23, 2024
ChristopherChristofi
approved these changes
Oct 23, 2024
ChristopherChristofi
left a comment
ChristopherChristofi
left a comment
Member
There was a problem hiding this comment.
Thank you for the patch, looks good to me and can build successfully
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
bernhardkaindl
added
bugfix
lang-m
force-pushed
the
fix-miniforge-sbang
branch
from
October 24, 2024 08:57
8c024e8 to
dc38e78
Compare
bernhardkaindl
approved these changes
Oct 24, 2024
bernhardkaindl
removed
needs-minor-cleanup
changes-requested
This was referenced Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the sbang line conda replaces the full path to the Python executable with
/usr/bin/env pythonif the full path exceeds 127 characters. This does however breakconda deactivatebecause the wrong Python interpreter is used after activating an environment. The 127 character limit is not relevant in Spack as Spack will automatically use thesbangscript to deal with the overly long sbang line.There is no option to disable this replacement when running the miniforge installer, so the lines have to be changed after running the installer.