Skip to content

openPMD-api: Fix pybind11 3.0.2 - #3470

Merged
bernhardkaindl merged 1 commit into
spack:developfrom
ax3l:fix-openpmd-api-pybind302
Jul 11, 2026
Merged

openPMD-api: Fix pybind11 3.0.2#3470
bernhardkaindl merged 1 commit into
spack:developfrom
ax3l:fix-openpmd-api-pybind302

Conversation

@ax3l

@ax3l ax3l commented Feb 18, 2026

Copy link
Copy Markdown
Member

Hotfix: Python property lifetime fix & pybind11 3.0.2 support

Hotfix: Python property lifetime fix & pybind11 3.0.2 support
@ax3l ax3l added build-error python patch Modifications to packages' sets of defined patches e4s labels Feb 18, 2026
@spackbot-triage spackbot-triage Bot added update-package Modifications to packages in the repository and removed python labels Feb 18, 2026
@ax3l
ax3l requested a review from franzpoeschel February 18, 2026 06:28
@haampie

haampie commented Feb 18, 2026

Copy link
Copy Markdown
Member

👋 @ax3l, the new find_package(pybind11 3.0.0 CONFIG REQUIRED) bit means you have to add

depends_on("py-pybind11@3:", type="link", when="@0.17")

too, right?

(And maybe type="link" could be type="build" for pybind11, I think it's header only and CMake should be able to find it with build type)

@bernhardkaindl

Copy link
Copy Markdown
Contributor

@ax3l I see you sent a 👍 for #3470 (comment)

@ax3l

ax3l commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

Oh I thought I fixed that already

@ax3l

ax3l commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

PR #5300 fixes the pybind11 dep, we need both

@ax3l ax3l mentioned this pull request Jul 11, 2026
@bernhardkaindl

Copy link
Copy Markdown
Contributor

@ax3l Thanks for the updated info! As you're the experts, assume that this is ready for merge right after merging #5300.

@bernhardkaindl bernhardkaindl self-assigned this Jul 11, 2026
@bernhardkaindl
bernhardkaindl merged commit 800d694 into spack:develop Jul 11, 2026
17 of 18 checks passed
d-reynolds pushed a commit to d-reynolds/spack-packages that referenced this pull request Jul 27, 2026
Hotfix: Python property lifetime fix & pybind11 3.0.2 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-error e4s patch Modifications to packages' sets of defined patches update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants