hip: set --gcc-install-dir instead of --gcc-toolchain #2420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-triage
bot
requested review from
afzpatel,
haampie,
renjithravindrankannath and
srekolam
rbberger
force-pushed
the
updates/hip
branch
from
137494d to
d593dff
Compare
afzpatel
approved these changes
Nov 17, 2025
srekolam
approved these changes
Nov 17, 2025
renjithravindrankannath
approved these changes
Nov 17, 2025
becker33
reviewed
Jan 9, 2026
Comment on lines
427
to
430
| env.append_path("HIPCC_COMPILE_FLAGS_APPEND", gcc_install_dir_flag, separator=" ") | ||
| env.append_path("HIPCC_LINK_FLAGS_APPEND", gcc_install_dir_flag, separator=" ") | ||
| # This is picked up by CMake when using HIP as a CMake language. | ||
| env.append_path("HIPFLAGS", gcc_install_dir_flag, separator=" ") |
Member
There was a problem hiding this comment.
I think you can use env.append_flags to avoid having to explicitly set the separator.
becker33
previously approved these changes
Jan 9, 2026
spackbot-triage
bot
requested review from
afzpatel,
renjithravindrankannath and
srekolam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
--gcc-toolchainhas been discouraged by LLVM for some time now (see llvm/llvm-project#77537). While--gcc-toolchainstill works, this should future proofs the hip dependent package logic.Note
The
setup_dependent_build_environmentlogic in thehippackages depends on a compiler dependency. However, > externals don't automatically gain one during concretization. So this should be better documented.Externals of
hipcan specify a GCC compiler so that the correct GCC installation is selected forhipcc. This becomes > relevant for compilations with newer C++ standards, where the default system GCC might be too old.