Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3669: Updating the C Extension to do CHARGELOSS Read Noise Recalculations #275

Merged
merged 36 commits into from
Sep 10, 2024
Merged

JP-3669: Updating the C Extension to do CHARGELOSS Read Noise Recalculations #275

merged 36 commits into from
Sep 10, 2024

Commits on Sep 9, 2024

  1. Adding chargeless handler stub.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5c42172 View commit details
    Browse the repository at this point in the history

  2. Updating debugging function.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    096d3ab View commit details
    Browse the repository at this point in the history

  3. Setting up chargeloss test for ramp fitting.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4ac254d View commit details
    Browse the repository at this point in the history

  4. Updating git ignore file to ignore swp files.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    29549b0 View commit details
    Browse the repository at this point in the history

  5. Changed variables in segment computation for ramp fitting in order to… 

    … prepare for function signature change.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    554e892 View commit details
    Browse the repository at this point in the history

  6. Updating ramp fitting tests in preparation for the chargeloss flag.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8f37c80 View commit details
    Browse the repository at this point in the history

  7. Generalized the ramp fitting computation of an integration into segme… 

    …nts to be more flexible.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bdfd518 View commit details
    Browse the repository at this point in the history

  8. Refactoring segment read noise calculation for ramp fitting C extension.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    373d6d7 View commit details
    Browse the repository at this point in the history

  9. Refactoring the length 1 group segment computation for ramp fitting.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ff85dda View commit details
    Browse the repository at this point in the history

  10. Adding the chargeloss read noise re-computation to the C extension in… 

    … ramp fitting.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6e4beff View commit details
    Browse the repository at this point in the history

  11. Skipping chargeloss test in ramp fitting for now.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6f9dfc1 View commit details
    Browse the repository at this point in the history

  12. Forcing C extension usage in ramp fitting during testing, but comment… 

    …ed out by default.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    01fee1a View commit details
    Browse the repository at this point in the history

  13. Adding some debugging to the ramp fit chargeloss test.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8c4bc4a View commit details
    Browse the repository at this point in the history

  14. Updating and expanding comments for the new code in the ramp fitting … 

    …C extension.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    641847e View commit details
    Browse the repository at this point in the history

  15. Adding a copy of the original GDQ array to the RampData class.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3cee7cb View commit details
    Browse the repository at this point in the history

  16. Adding a copy of the original GDQ array to the RampData class.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    30a4744 View commit details
    Browse the repository at this point in the history

  17. Adding a copy of the original GDQ array to the RampData class.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0e3d5f8 View commit details
    Browse the repository at this point in the history

  18. Debugging the problems found in a small number of CHARGELOSS recomput… 

    …ation for the read noise variance in ramp fitting. The test_niriss_image.py 'rate' tests are failing for less than one percent of the CHARGELOSS affected pixels.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7a43c11 View commit details
    Browse the repository at this point in the history

  19. Updating the search for CHARGELOSS flags in the group DQ array during… 

    … the creation of the RampData array during ramp fitting.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    20a4108 View commit details
    Browse the repository at this point in the history

  20. Updating the ramp fitting C extension to properly recompute the read … 

    …noise variance due to the CHARGELOSS flag.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1e1b8e7 View commit details
    Browse the repository at this point in the history

  21. Updated testing to prevent segfault.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    186d2a2 View commit details
    Browse the repository at this point in the history

  22. Rebase prep commit.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    95589ab View commit details
    Browse the repository at this point in the history

  23. Removing debugging statements.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8f56fe6 View commit details
    Browse the repository at this point in the history

  24. Removing debugging statements.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ed36550 View commit details
    Browse the repository at this point in the history

  25. Updating the change log.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a94568e View commit details
    Browse the repository at this point in the history

  26. Removing debugging flag so the OLS algorithm can be selected.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    82b90c8 View commit details
    Browse the repository at this point in the history

  27. Updating the changelog based on code review feedback.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a00f4cd View commit details
    Browse the repository at this point in the history

  28. Updating the creation of a copy of the original group DQ array to be … 

    …conditioned on the use of the 'OLS_C' ramp fitting algorithm.
    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    dc40a82 View commit details
    Browse the repository at this point in the history

  29. Adding missing doctring for new method parameter.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6ebd9e0 View commit details
    Browse the repository at this point in the history

  30. Correcting misspelling in comments.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3b44cd0 View commit details
    Browse the repository at this point in the history

  31. Updating ramp fitting tests.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d24f865 View commit details
    Browse the repository at this point in the history

  32. Adding PR fragment to changes for the change log.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bd53ce8 View commit details
    Browse the repository at this point in the history

  33. Adding CHARGELOSS keyword to DQ flags for testing.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b7dc9a8 View commit details
    Browse the repository at this point in the history

  34. Making changes handling CHARGELOSS flagging for RomanCal.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e893cf1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Updating test_cext_chargeloss.

    @kmacdonald-stsci
    kmacdonald-stsci committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2ee4a85 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jp_3669

    @tapastro
    tapastro authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d85f859 View commit details
    Browse the repository at this point in the history