Skip to content

Add python 3.12 devdeps testing - #886

Merged
WilliamJamieson merged 3 commits into
spacetelescope:mainfrom
WilliamJamieson:testing/python3.12
Feb 5, 2024
Merged

Add python 3.12 devdeps testing#886
WilliamJamieson merged 3 commits into
spacetelescope:mainfrom
WilliamJamieson:testing/python3.12

Conversation

@WilliamJamieson

Copy link
Copy Markdown
Collaborator

Add python 3.12 devdeps testing.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@WilliamJamieson

Copy link
Copy Markdown
Collaborator Author

The devdeps tests are blocked by an issue in deepdiff, please see qlustered/deepdiff#422 for details.

@schlafly schlafly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Sep 27, 2023
@codecov

codecov Bot commented Sep 27, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79293f3) 76.80% compared to head (8341839) 76.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         105      105           
  Lines        7035     7035           
=======================================
  Hits         5403     5403           
  Misses       1632     1632           
Flag Coverage Δ *Carryforward flag
nightly 62.99% <ø> (ø) Carriedforward from f61ff4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson

Copy link
Copy Markdown
Collaborator Author

Should we merge this even if there are many failures that appear to be from Numpy 2.0 effecting upstream packages?

@zacharyburnett

Copy link
Copy Markdown
Collaborator

Should we merge this even if there are many failures that appear to be from Numpy 2.0 effecting upstream packages?

I'd say yes, as long as the failures aren't related to Python 3.12; the Numpy failures can be another PR

@WilliamJamieson
WilliamJamieson merged commit 9e3cf53 into spacetelescope:main Feb 5, 2024
@WilliamJamieson
WilliamJamieson deleted the testing/python3.12 branch February 5, 2024 20:45
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants