Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moment map continuum unit conversion #3212

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 4, 2024

Description

This pull request implements the ability for the continuum mixin to handle unit conversion within the preview marks themselves, and makes use of that within the moment map plugin, but leaving line analysis to do unit conversion within the plugin since we want to recompute results to expose in the table during a unit conversion change.

See #3211 (comment)

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* and do so automatically for moment maps (but not for line analysis)
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Oct 4, 2024
@kecnry kecnry added this to the 4.0 milestone Oct 4, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Oct 4, 2024
@kecnry kecnry marked this pull request as ready for review October 4, 2024 18:44
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (12d3b04) to head (14a6801).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/core/template_mixin.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3212      +/-   ##
==========================================
+ Coverage   88.49%   88.53%   +0.04%     
==========================================
  Files         125      125              
  Lines       18671    18677       +6     
==========================================
+ Hits        16522    16535      +13     
+ Misses       2149     2142       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, thanks!

@pllim pllim merged commit 0f46989 into spacetelescope:main Oct 7, 2024
20 of 23 checks passed
@kecnry kecnry deleted the mm-continuum-units branch October 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants