Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface brightness -> solid angle conversion updates #3111

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Surface brightness -> solid angle conversion updates #3111

merged 12 commits into from
Aug 1, 2024

Commits on Jul 30, 2024

  1. first pass at sb -> angle drop down changes

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    297deca View commit details
    Browse the repository at this point in the history

  2. update conversion logic, .pix support for counts

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8a1a919 View commit details
    Browse the repository at this point in the history

  3. update tests, cut out sb code

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9b93ad6 View commit details
    Browse the repository at this point in the history

  4. add comments, handle limits and choices

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0f4c247 View commit details
    Browse the repository at this point in the history

  5. add change log

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9f5fdfb View commit details
    Browse the repository at this point in the history

  6. handle load_data case where PIXAR_SR not in metadata, reset limits ad… 

    …justment
    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    127e4c4 View commit details
    Browse the repository at this point in the history

  7. u.erg/u.s/u.cm**2/u.Angstrom in untranslatable units, switch from SB … 

    …to flux for test
    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3999af2 View commit details
    Browse the repository at this point in the history

  8. get_object -> get_component, 2 returns to 1

    @gibsongreen
    gibsongreen committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9d6ac06 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. broadcast sb_unit, fix zoom limits, ensure self.sb_unit sets

    @gibsongreen
    gibsongreen committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e08d7b5 View commit details
    Browse the repository at this point in the history

  2. reconcile test failures

    @gibsongreen
    gibsongreen committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3b523d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. remove flux_or_sb extra conditions, small comment tweak

    @gibsongreen
    gibsongreen committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    68a1ead View commit details
    Browse the repository at this point in the history

  2. sb_unit -> sb_unit_selected for app._get_display_unit(sb) compatibility

    @gibsongreen
    gibsongreen committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    96b9263 View commit details
    Browse the repository at this point in the history