Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual backport of PR #3096 #3105

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 22, 2024

This PR is a manual backport of #3096 (conflict was due to #2896 not being in 3.10.x but that had a switch in #3096 to hide that entry when running on an external server).

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Jul 22, 2024
@kecnry kecnry added this to the 3.10.3 milestone Jul 22, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jul 22, 2024
@kecnry
Copy link
Member Author

kecnry commented Jul 22, 2024

@bmorris3 @pllim (as reviewers of the original PR), can you please approve this? See description for explanation of the conflict, otherwise the diff is unchanged.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (96cebe3) to head (05ab111).

Additional details and impacted files
@@           Coverage Diff            @@
##           v3.10.x    #3105   +/-   ##
========================================
  Coverage    88.91%   88.91%           
========================================
  Files          111      111           
  Lines        17176    17179    +3     
========================================
+ Hits         15272    15275    +3     
  Misses        1904     1904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim
Copy link
Contributor

pllim commented Jul 22, 2024

Since this is just a backport, one approval is enough. Merging. Thanks!

@pllim pllim merged commit d61d749 into spacetelescope:v3.10.x Jul 22, 2024
22 of 24 checks passed
@kecnry kecnry deleted the backport-3096 branch July 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants