Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser title jdaviz #2916

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

haticekaratay
Copy link
Contributor

Description

This pull request is to add browser title "jdaviz" to standalone. Previously, it would launch with a default localhost:... .
Before:
image

After:
image

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@haticekaratay haticekaratay added this to the 4.0 milestone Jun 12, 2024
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (fb6c435) to head (d71d3e9).
Report is 150 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2916   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         111      111           
  Lines       17178    17178           
=======================================
  Hits        15248    15248           
  Misses       1930     1930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haticekaratay haticekaratay added the trivial Only needs one approval instead of two label Jun 12, 2024
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad it's so simple! 🎉

@bmorris3 bmorris3 merged commit 4b8be8f into spacetelescope:main Jun 12, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants