Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded 'Subset' string checks #2611

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Dec 12, 2023

Does what the title says.

@rosteen rosteen added this to the 3.9 milestone Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0673de8) 91.54% compared to head (7feaf19) 91.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
jdaviz/core/template_mixin.py 93.38% 8 Missing ⚠️
...configs/cubeviz/plugins/moment_maps/moment_maps.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2611   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         161      161           
  Lines       19757    19837   +80     
=======================================
+ Hits        18086    18160   +74     
- Misses       1671     1677    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically all the checks are now double loops (one loop to find all the subset labels and another loop to check if a given label is in those labels). Is there a smarter way to check whether something is a subset without using label at all? 💭

@gibsongreen gibsongreen modified the milestones: 3.9, 3.10 Apr 5, 2024
@bmorris3 bmorris3 modified the milestones: 3.10, 3.11 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants