-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update roman WFI test file for latest rad/rdm #2302
Conversation
f6d6281
to
b20ded7
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 90.95% 90.96% +0.01%
==========================================
Files 152 152
Lines 17198 17196 -2
==========================================
Hits 15642 15642
+ Misses 1556 1554 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only seems contained to this test, which is passing CI (other than known Glue-Jupyter dev failure)
…2-on-v3.5.x Backport PR #2302 on branch v3.5.x (Update roman WFI test file for latest rad/rdm)
Description
The latest releases of
roman_datamodels
(0.16.1) andrad
(0.16.0) have updated schema. If we run tests with these latest releases, the Roman WFI package data can't be read, raisingjsonschema.exceptions.ValidationError: 'read_pattern' is a required property
(since spacetelescope/rad#233 was released).This PR updates the ASDF package data file, and revises the test to remove a catch for a formerly expected warning that's been resolved upstream.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.