Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roman WFI test file for latest rad/rdm #2302

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

bmorris3
Copy link
Contributor

Description

The latest releases of roman_datamodels (0.16.1) and rad (0.16.0) have updated schema. If we run tests with these latest releases, the Roman WFI package data can't be read, raising jsonschema.exceptions.ValidationError: 'read_pattern' is a required property (since spacetelescope/rad#233 was released).

This PR updates the ASDF package data file, and revises the test to remove a catch for a formerly expected warning that's been resolved upstream.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the imviz label Jul 18, 2023
@bmorris3 bmorris3 added testing no-changelog-entry-needed changelog bot directive 💤 backport-v3.5.x on-merge: backport to v3.5.x labels Jul 18, 2023
@bmorris3 bmorris3 added this to the 3.5.1 milestone Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (0f3f4f6) 90.95% compared to head (3dbf504) 90.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2302      +/-   ##
==========================================
+ Coverage   90.95%   90.96%   +0.01%     
==========================================
  Files         152      152              
  Lines       17198    17196       -2     
==========================================
  Hits        15642    15642              
+ Misses       1556     1554       -2     
Impacted Files Coverage Δ
jdaviz/configs/imviz/tests/test_parser_roman.py 11.11% <0.00%> (+1.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bmorris3 bmorris3 marked this pull request as ready for review July 19, 2023 12:51
@bmorris3 bmorris3 added the bug Something isn't working label Jul 19, 2023
Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only seems contained to this test, which is passing CI (other than known Glue-Jupyter dev failure)

@bmorris3 bmorris3 added the trivial Only needs one approval instead of two label Jul 19, 2023
@bmorris3 bmorris3 merged commit c6a66c4 into spacetelescope:main Jul 19, 2023
20 of 22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jul 19, 2023
pllim added a commit that referenced this pull request Jul 24, 2023
…2-on-v3.5.x

Backport PR #2302 on branch v3.5.x (Update roman WFI test file for latest rad/rdm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.5.x on-merge: backport to v3.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants