Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to get_data to apply spectral subset to collapse spatial #2199

Merged
merged 21 commits into from
May 24, 2023
Merged

Add option to get_data to apply spectral subset to collapse spatial #2199

merged 21 commits into from
May 24, 2023

Commits on May 12, 2023

  1. Add option to get_data to apply spectral subset to collapse spatial

    @javerbukh
    javerbukh committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e1e30e7 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Fix tests that use get_data

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    797096e View commit details
    Browse the repository at this point in the history

  2. Implement review comments

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b9cd460 View commit details
    Browse the repository at this point in the history

  3. Apply spectral subset mask to collapsed spatial subset

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b2f3f79 View commit details
    Browse the repository at this point in the history

  4. Update docstrings

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    edd3b55 View commit details
    Browse the repository at this point in the history

  5. Add tests

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dd13038 View commit details
    Browse the repository at this point in the history

  6. Fix style checks

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dfd7d60 View commit details
    Browse the repository at this point in the history

  7. Change error message

    @javerbukh
    javerbukh committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ff0ecb6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Add explicit get_data to imviz

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    da88b3b View commit details
    Browse the repository at this point in the history

  2. Raise error when cubeviz kwargs are used in specviz get_data

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    1831afd View commit details
    Browse the repository at this point in the history

  3. Implement review requests

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    01207fd View commit details
    Browse the repository at this point in the history

  4. Add get_data to specviz2d

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b9203d7 View commit details
    Browse the repository at this point in the history

  5. Add line to fix CI

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    8389ee4 View commit details
    Browse the repository at this point in the history

  6. Make sure function is respected with just spatial subset

    @javerbukh
    javerbukh committed May 22, 2023
    Configuration menu
    Copy the full SHA
    afca9a9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add more catches for incorrect or invalid parameters

    @javerbukh
    javerbukh committed May 23, 2023
    Configuration menu
    Copy the full SHA
    dea9920 View commit details
    Browse the repository at this point in the history

  2. Fix style check

    @javerbukh
    javerbukh committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3b22c46 View commit details
    Browse the repository at this point in the history

  3. Cover case where cubeviz.get_data uses spectral subset and function

    @javerbukh
    javerbukh committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d4fe3fa View commit details
    Browse the repository at this point in the history

  4. Fix bug with get_spectra

    @javerbukh
    javerbukh committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e49baab View commit details
    Browse the repository at this point in the history

  5. Switch mask to be False where spectral subset is applied

    @javerbukh
    javerbukh committed May 23, 2023
    Configuration menu
    Copy the full SHA
    43a342f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Add get_data to mosviz

    @javerbukh
    javerbukh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e84a308 View commit details
    Browse the repository at this point in the history

  2. Update change file

    @javerbukh
    javerbukh committed May 24, 2023
    Configuration menu
    Copy the full SHA
    155bc85 View commit details
    Browse the repository at this point in the history