[Merged by Bors] - v1.6: revert libp2p upgrade changes from #5961 #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6017 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 296 296
Lines 31683 31683
=========================================
- Hits 25789 25781 -8
- Misses 4212 4219 +7
- Partials 1682 1683 +1 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Jun 7, 2024
fasmat
approved these changes
Jun 7, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## Motivation Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
4 tasks
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
## Motivation `go-libp2p` v0.34.0 had to be rolled back because of a bug that was introduced and affected go-spacemesh, for details see: #6017 Since then `go-libp2p` v0.35.1 has been released that fixes the issue. Upgrading to this version would also allow us to update other dependencies that are currently blocked.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
## Motivation `go-libp2p` v0.34.0 had to be rolled back because of a bug that was introduced and affected go-spacemesh, for details see: #6017 Since then `go-libp2p` v0.35.1 has been released that fixes the issue. Upgrading to this version would also allow us to update other dependencies that are currently blocked.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
## Motivation `go-libp2p` v0.34.0 had to be rolled back because of a bug that was introduced and affected go-spacemesh, for details see: #6017 Since then `go-libp2p` v0.35.1 has been released that fixes the issue. Upgrading to this version would also allow us to update other dependencies that are currently blocked.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
## Motivation `go-libp2p` v0.34.0 had to be rolled back because of a bug that was introduced and affected go-spacemesh, for details see: #6017 Since then `go-libp2p` v0.35.1 has been released that fixes the issue. Upgrading to this version would also allow us to update other dependencies that are currently blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
Description
Revert version bump of libp2p libs from #5961
For the
developbranch, I intend to fix the libp2p issue