Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspc v3 syntax #628

Closed
wants to merge 3 commits into from
Closed

rspc v3 syntax #628

wants to merge 3 commits into from

Conversation

oscartbeaumont
Copy link
Contributor

@oscartbeaumont oscartbeaumont commented Mar 20, 2023

This is an experimental branch using the alpha version of the rspc v3 syntax. It also comes with the new version of Specta which provides stupidly better error handling and a large number of bug fixes.

I spent the weekend working with @Brendonovich on this and we have got some stuff working which will greatly help with the maintainability of our rspc integration as it means we can remove all uses of private rspc APIs (of which we have a lot). Currently, it takes me 2-6 hours of updating Spacedrive when rspc does any non-minor changes which is pretty bad.

These changes also come with a shift in the mental model which should make more sense and allow us to make better use of middleware which will help to solve many challenges such as authentication as we get further into launching our product.

TODO:

  • Get frontend talking with Rust again
  • Fix RN transport

@linear
Copy link

linear bot commented Mar 20, 2023

ENG-444 rspc syntax v3

It would be nice if upgrading rspc wasn't always a multi hour process.

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2023 at 1:00PM (UTC)
spacedrive-web ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2023 at 1:00PM (UTC)

@oscartbeaumont oscartbeaumont mentioned this pull request Apr 1, 2023
38 tasks
@oscartbeaumont
Copy link
Contributor Author

oscartbeaumont commented Apr 25, 2023

Closed in favor of #756 and #758

@oscartbeaumont oscartbeaumont deleted the eng-444-rspc-syntax-v3 branch April 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants