Fix MiniMax fallback routing - #84
Closed
Marenz wants to merge 2 commits into
Closed
Conversation
Marenz
force-pushed
the
pr/fix-oauth-minimax
branch
2 times, most recently
from
February 21, 2026 01:24
28e9916 to
908bbb7
Compare
Marenz
force-pushed
the
pr/fix-oauth-minimax
branch
from
February 21, 2026 10:35
908bbb7 to
65093c5
Compare
Marenz
changed the title
Collaborator
Author
|
Dropped the OAuth workaround commit — #100 solves that more cleanly at the LlmManager level. This PR now only contains the MiniMax routing fix and the warn-level log upgrade. |
Marenz
force-pushed
the
pr/fix-oauth-minimax
branch
from
February 22, 2026 00:04
65093c5 to
fcfe290
Compare
MiniMax was configured as ApiType::Anthropic, but build_anthropic_request hardcodes api.anthropic.com. Requests were sent to Anthropic with a MiniMax key, producing 401 invalid x-api-key. Switch to ApiType::OpenAiCompletions with base_url api.minimax.io — their OpenAI-compatible endpoint works correctly.
The debug log for empty assistant_content was invisible at default log level. Upgrade to warn so we can see stop_reason and raw content when the API returns an empty content array.
Marenz
force-pushed
the
pr/fix-oauth-minimax
branch
from
February 23, 2026 15:10
fcfe290 to
05cd3d3
Compare
Collaborator
Author
|
While this PR was open, the Anthropic path was fixed to correctly use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax was configured as
ApiType::Anthropicwithbase_url: api.minimax.io/anthropic, butbuild_anthropic_requesthardcodesapi.anthropic.com/v1/messages. MiniMax requests were sent to Anthropic's API with a MiniMax key, producinginvalid x-api-key.Fix: switch MiniMax to
ApiType::OpenAiCompletionswithbase_url: api.minimax.io— their OpenAI-compatible endpoint works correctly.Also upgrades the empty-response log from
debug!towarn!for better observability.Fixes #147