fix(ci): stop re-downloading the embedding model in memory tests - #619
Merged
Conversation
The search tests initialized fastembed into per-test tempdirs, so every run downloaded the ONNX model from Hugging Face — intermittent failures turned unrelated PRs red twice today. All tests now share one model via a stable cache path, and CI caches that path across runs.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiepine
marked this pull request as ready for review
August 8, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory search tests initialized
EmbeddingModelinto per-test tempdirs, so every test (and every CI run) downloaded the ONNX model from Hugging Face. That download failed intermittently — it turned #372 and #606 red today on unrelated diffs.shared_test_model()(the pattern maintenance.rs already used), downloading once into a stable cache path/tmp/spacebot-test-embedding-cacheacross runs, so a green run seeds every later run and Hugging Face drops out of the hot pathLocally the memory test suite goes from N downloads to one (cached: zero).