Skip to content

fix(ci): pin Rust 1.97.1, bump ethnum, clear clippy lints on current stable - #617

Merged
jamiepine merged 1 commit into
mainfrom
fix/ci-toolchain
Aug 8, 2026
Merged

fix(ci): pin Rust 1.97.1, bump ethnum, clear clippy lints on current stable#617
jamiepine merged 1 commit into
mainfrom
fix/ci-toolchain

Conversation

@jamiepine

@jamiepine jamiepine commented Aug 8, 2026

Copy link
Copy Markdown
Member

CI has been red for every Rust check since stable moved past 1.93, on every PR and on main itself. Two causes stacked:

  • ethnum 1.5.2 (pulled in via jsonb) fails to compile on current stable — error[E0512] on a mem::transmute(()) into TryFromIntError. Fixed upstream in 1.5.3.
  • once past that, clippy on 1.97 flags 7 lints in existing code that -Dwarnings turns into errors.

Because the workflow floated on dtolnay/rust-toolchain@stable, every stable release could (and did) break all open PRs at once, while local builds on older toolchains kept passing — which is why it went unnoticed.

Changes:

  • bump ethnum 1.5.2 -> 1.5.3 in the lockfile
  • pin the toolchain to 1.97.1 via rust-toolchain.toml and in ci.yml, so local builds and CI compile with the same rustc/clippy and a stable release can't take down CI again
  • fix the 7 clippy lints (.values() instead of iterating map tuples, Option::filter, ? operator, redundant format! ref)

Verified locally on 1.97.1: fmt, clippy --all-targets with -Dwarnings, 875 lib tests, gate-pr.

Note

Summary: Fixes CI failures by pinning Rust to 1.97.1, updating ethnum to 1.5.3, and clearing 7 clippy lints across activity, channels, workers, model, task store, and spawn_worker modules. All changes maintain existing functionality while ensuring consistent builds across local and CI environments.

Written by Tembo for commit d027b9d. This will update automatically on new commits.

…stable

CI has been red for every PR since stable moved past 1.93: ethnum 1.5.2
fails to compile (E0512 in its TryFromIntError transmute) and clippy on
1.97 flags lints in existing code that -Dwarnings turns into errors.
The toolchain floated on dtolnay/rust-toolchain@stable, so this hit
every branch at once while older local toolchains kept passing.

- bump ethnum 1.5.2 -> 1.5.3 (upstream fixed the transmute)
- pin 1.97.1 via rust-toolchain.toml and in ci.yml so local builds and
  CI compile with the same rustc/clippy
- fix the 7 clippy lints on 1.97 (map .values(), Option::filter,
  ? operator, redundant format! ref)
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 80629f32-8515-42fa-9916-25ce7c762de1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant