fix(ci): pin Rust 1.97.1, bump ethnum, clear clippy lints on current stable - #617
Merged
Conversation
…stable CI has been red for every PR since stable moved past 1.93: ethnum 1.5.2 fails to compile (E0512 in its TryFromIntError transmute) and clippy on 1.97 flags lints in existing code that -Dwarnings turns into errors. The toolchain floated on dtolnay/rust-toolchain@stable, so this hit every branch at once while older local toolchains kept passing. - bump ethnum 1.5.2 -> 1.5.3 (upstream fixed the transmute) - pin 1.97.1 via rust-toolchain.toml and in ci.yml so local builds and CI compile with the same rustc/clippy - fix the 7 clippy lints on 1.97 (map .values(), Option::filter, ? operator, redundant format! ref)
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiepine
marked this pull request as ready for review
August 8, 2026 03:48
This was referenced Aug 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been red for every Rust check since stable moved past 1.93, on every PR and on main itself. Two causes stacked:
ethnum1.5.2 (pulled in viajsonb) fails to compile on current stable —error[E0512]on amem::transmute(())intoTryFromIntError. Fixed upstream in 1.5.3.-Dwarningsturns into errors.Because the workflow floated on
dtolnay/rust-toolchain@stable, every stable release could (and did) break all open PRs at once, while local builds on older toolchains kept passing — which is why it went unnoticed.Changes:
ethnum1.5.2 -> 1.5.3 in the lockfilerust-toolchain.tomland inci.yml, so local builds and CI compile with the same rustc/clippy and a stable release can't take down CI again.values()instead of iterating map tuples,Option::filter,?operator, redundantformat!ref)Verified locally on 1.97.1: fmt,
clippy --all-targetswith-Dwarnings, 875 lib tests,gate-pr.Note
Summary: Fixes CI failures by pinning Rust to 1.97.1, updating ethnum to 1.5.3, and clearing 7 clippy lints across activity, channels, workers, model, task store, and spawn_worker modules. All changes maintain existing functionality while ensuring consistent builds across local and CI environments.
Written by Tembo for commit d027b9d. This will update automatically on new commits.