fix: collapse nested if statements in signal adapter routing - #402
Conversation
Fixes clippy collapsible_if lint introduced by the Signal adapter merge. Two nested if blocks in send_message_to_another_channel are collapsed into single conditional expressions using let chains.
WalkthroughRefactored conditional logic in Signal message routing to streamline explicit and implicit Signal shorthand handling. Combined nested if structures into single conditionals using if-let binding patterns. Maintains existing behavior for broadcasting, error handling, and logging while reducing code complexity. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — this change is included verbatim in #401 (same hunks in send_message_to_another_channel.rs), so it'll land there. Thanks! |
Summary
Fixes clippy
collapsible_iflint introduced by the Signal adapter merge (#347). Two nested if blocks insend_message_to_another_channel.rsare collapsed into single conditional expressions using let chains.This is currently breaking CI on all PRs branched from main.
Test plan
cargo clippy --all-targets -- -D warningspasses cleanNote
AI Summary: Collapses two nested if blocks into single conditions using let chains. First block (lines 153-160) combines the adapter check with optional current adapter assignment. Second block (lines 191-207) combines the implicit signal shorthand check with target parsing, reducing nesting and improving readability. Changes are purely structural with no logic modification.
Written by Tembo for commit 0faf9c8. This will update automatically on new commits.