Skip to content

Fix UTF-8 boundary panic in cortex_chat and discord reply truncation #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamiepine merged 4 commits into from
Mar 3, 2026
Merged

Fix UTF-8 boundary panic in cortex_chat and discord reply truncation #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f223009
fix: use floor_char_boundary for string truncation to prevent UTF-8 p…
l33t0 Mar 1, 2026
767799e
refactor: extract floor_char_boundary to local for readability
l33t0 Mar 1, 2026
a611056
Merge branch 'main' into fix/cortex-utf8-boundary-panic
jamiepine Mar 3, 2026
19d2754
Merge branch 'main' into fix/cortex-utf8-boundary-panic
jamiepine Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agent/cortex_chat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ impl<M: CompletionModel> PromptHook<M> for CortexChatHook {
result: &str,
) -> HookAction {
let preview = if result.len() > 200 {
format!("{}...", &result[..200])
let end = result.floor_char_boundary(200);
format!("{}...", &result[..end])
} else {
result.to_string()
};
Expand Down
5 changes: 4 additions & 1 deletion src/messaging/discord.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,10 @@ async fn build_metadata(
let reply_content = resolve_mentions(&referenced.content, &referenced.mentions);
// Truncate to avoid bloating context with long quoted messages
let truncated = if reply_content.len() > 200 {
format!("{}...", &reply_content[..200])
format!(
"{}...",
&reply_content[..reply_content.floor_char_boundary(200)]
)
} else {
reply_content
};
Expand Down