Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we pin the version numbers of dependencies for the demos? #127

Open
mkhansenbot opened this issue Jan 30, 2024 · 1 comment
Open

Should we pin the version numbers of dependencies for the demos? #127

mkhansenbot opened this issue Jan 30, 2024 · 1 comment
Assignees
@mkhansenbot

Comments

@mkhansenbot
Copy link
Contributor

Currently the repos files for the moveit2 and navigation2 dependencies use branch names (humble, ros2, etc). Should we pin those to specific version numbers that are known to work?

The pro is that then we ensure we don't break the demos. The con is that we may break the demos when the source code for moveit2 or nav2 "humble" branches move forward.
@mkhansenbot mkhansenbot self-assigned this Jan 30, 2024
@mkhansenbot mkhansenbot mentioned this issue Jan 30, 2024
Merged
@mkhansenbot mkhansenbot added this to the humble-2024.04.0 milestone Jan 30, 2024
@mkhansenbot
Copy link
Contributor Author

Added to next milestone (proposed) humble-2024.04.0

@mkhansenbot mkhansenbot removed this from the humble-2024.04.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkhansenbot mkhansenbot

Labels
None yet
Projects
Space ROS Project Development
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkhansenbot