merge metrics across workers #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keksoj
force-pushed
the
flatten-cluster-metrics
branch
3 times, most recently
from
48f7645
to
f6f7ed3
Compare
Keksoj
changed the title
Keksoj
force-pushed
the
flatten-cluster-metrics
branch
from
f6f7ed3
to
707001b
Compare
Keksoj
changed the title
Keksoj
force-pushed
the
flatten-cluster-metrics
branch
from
ac6dbdd
to
dfafe7e
Compare
llenotre
approved these changes
Jul 9, 2024
Keksoj
force-pushed
the
flatten-cluster-metrics
branch
from
dfafe7e
to
586b608
Compare
The default behaviour is now to take all metrics from the AggregatedMetrics object, merge them by cluster id, and move them to the field AggregatedMetrics::clusters. The behaviour is avoidable with the option "metrics get --workers" Note: the function merge_cluster_metrics does not merge time metrics (percentiles), they are discarded. Prometheus histograms should be mergeable though, if bucket size is consistent.
Keksoj
force-pushed
the
flatten-cluster-metrics
branch
from
586b608
to
6b4b96b
Compare
llenotre
approved these changes
Jul 9, 2024
Wonshtrum
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, querying metrics would yield all metrics of all workers, which means cluster metrics are consultable only this way:
The default behaviour is now to take all worker metrics from the AggregatedMetrics object, merge them by worker id or cluster id, and move them to the field
AggregatedMetrics::clustersorAggregatedMetrics::proxying, which allows to display metrics this way:The behaviour is avoidable with the option "metrics get --workers"
Note: the function
merge_metricsdoes not merge time metrics (percentiles), they are discarded. Prometheus histograms should be mergeable though, if bucket size is consistent.